Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix call list datasources api returns error #1789

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Fix call list datasources api returns error #1789

wants to merge 1 commit into from

Conversation

chaplinthink
Copy link
Contributor

Closes #1788

Description

API endpoint returns incorrect data type, it should be List type.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Snapshots:

Include snapshots for easier review.

Checklist:

  • My code follows the style guidelines of this project
  • I have already rebased the commits and make the commit message conform to the project standard.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules

@github-actions github-actions bot added the fix Bug fixes label Aug 7, 2024
@fangyinc fangyinc requested a review from Aries-ckt August 9, 2024 01:36
Aries-ckt

This comment was marked as outdated.

Sign in to view

@Aries-ckt
Copy link
Collaborator

@chaplinthink , thanks for your contribution, could you add the page result for /datasources api?

@chaplinthink
Copy link
Contributor Author

chaplinthink commented Aug 9, 2024 •
edited
Loading

@chaplinthink , thanks for your contribution, could you add the page result for /datasources api?

@Aries-ckt I used datasources client api, reference: http://docs.dbgpt.cn/docs/api/datasource#list-datasource

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aries-ckt Aries-ckt Aries-ckt approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
fix Bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] [Datasource API] Call list datasources api returns error
2 participants
@chaplinthink @Aries-ckt